Re: [Bluez-devel] [PATCH] Fix some bugs in hcidump.

[Marcel Holtmann <marcel@holtmann.org>]

Hi James,

> Each call to parse_de_hdr and print_uuid changes the value of frm->len.
> So, each time round the while loop (len - frm->len) becomes larger.
> 
> The n1 value is set by the previous line
> "if (parse_de_hdr(frm, &n1) == SDP_DE_SEQ) {"
> 
> This means we have n1 bytes of data we wish to parse inside the while loop.
> So, we want to start the while loop with (len - frm->len) == 0
> Each time round the loop (len - frm->len) will increase( due to calls to 
> parse_de_hdr and print_uuid) , and the loop will exit when (len - 
> frm->len) >= n1, which is what we want.
> 
> If we fail to set "len = frm->len;" just before the while loop, the 
> previous line
> "if (parse_de_hdr(frm, &n1) == SDP_DE_SEQ) {"
> changes frm->len, so the "int len = frm->len;" at the beginning of the 
> function is no longer correct.
> I.E. len != frm->len after the "if (parse_de_hdr(frm, &n1) == 
> SDP_DE_SEQ) {" statement.
> 
> I hope this explanation is clear.
> 
> Do you want me to resubmit the patch as a "cvs -u diff" ?

yes. And please remove the initial assignment of len.

Regards

Marcel




-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel