public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Franck Arnaud <franck@nenie.org>
Cc: BlueZ Mailing List <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] LIBS vs LD_FLAGS in bluez-utils makefiles
Date: Fri, 21 May 2004 17:53:49 +0200	[thread overview]
Message-ID: <1085154828.22191.3.camel@pegasus> (raw)
In-Reply-To: <45540213.2004.5.20.21.35.29.45662@mem.nenie.org>

Hi Franck,

> (let me know if you want it in another format.)

the format is quite right, but your mailer broke the patch. Maybe it is
better you attach it instead of inlining.

> diff --exclude=Makefile --exclude=Makefile.in -u -r 
> orig/bluez-utils-2.7/tools/Makefile.am bluez-utils-2.7/tools/Makefile.am
> --- orig/bluez-utils-2.7/tools/Makefile.am	Sun May  9 11:39:43 2004
> +++ bluez-utils-2.7/tools/Makefile.am	Thu May 20 14:38:06 2004
> @@ -10,17 +10,7 @@
>  
>  hciconfig_SOURCES = hciconfig.c csr.h csr.c
>  
> -hciconfig_LDFLAGS = @BLUEZ_LIBS@
> -
> -hcitool_LDFLAGS = @BLUEZ_LIBS@
> -
> -l2ping_LDFLAGS = @BLUEZ_LIBS@
> -
> -sdptool_LDFLAGS = @BLUEZ_LIBS@
> -
> -ciptool_LDFLAGS = @BLUEZ_LIBS@
> -
> -ppporc_LDFLAGS = @BLUEZ_LIBS@
> +LIBS = @BLUEZ_LIBS@
>  
>  INCLUDES = @BLUEZ_INCLUDES@

I am happy to apply your patch, but this is not what I want. Tools like
hciattach, hid2hci or hcisecfilter don't need to link -lbluetooth. What
is the correct way of solving this?

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

       reply	other threads:[~2004-05-21 15:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <45540213.2004.5.20.21.35.29.45662@mem.nenie.org>
2004-05-21 15:53 ` Marcel Holtmann [this message]
2004-05-21 16:40   ` [Bluez-devel] LIBS vs LD_FLAGS in bluez-utils makefiles Marcel Holtmann
2004-05-20 14:00 Franck Arnaud
  -- strict thread matches above, loose matches on Subject: below --
2004-05-20 13:56 Franck Arnaud
2004-05-20 14:22 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1085154828.22191.3.camel@pegasus \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    --cc=franck@nenie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox