Re: [Bluez-devel] [PATCH] Deleted acl-handles on failed hci_create_connection

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

Hi Andreas,

> Heres a patch for hci_event.c to fix the problem that acl-handles are removed 
> from the kernels connection hash when a hci_create_connection returnes a
> command status thats not 0x00.
> 
> One of the problems that was caused by this bug was that cc could be issued 
> even if the peer was already connected. This case leads to the error message 
> "Too many links" with sdptool and rfcomm for example. This connection could 
> only be removed if the acl handle was known otherwise or by removing power 
> from the usb-dongle (unplugg).

I think your patch is wrong, because in case of the first try through
L2CAP etc. a negative return value must result in a drop of the hci_conn
structure. Check if the attached patch is also working (againt 2.6).

Regards

Marcel


[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 411 bytes --]

===== net/bluetooth/hci_event.c 1.13 vs edited =====
--- 1.13/net/bluetooth/hci_event.c	2004-05-31 22:15:12 +02:00
+++ edited/net/bluetooth/hci_event.c	2004-06-10 20:48:55 +02:00
@@ -358,7 +358,7 @@
 			status, batostr(&cp->bdaddr), conn);
 
 	if (status) {
-		if (conn) {
+		if (conn && conn->state == BT_CONNECT) {
 			conn->state = BT_CLOSED;
 			hci_proto_connect_cfm(conn, status);
 			hci_conn_del(conn);