RE: [Bluez-devel] Alignment issue

Marcel Holtmann
2004-08-13T12:40:24Z

Hi David,

> I was overriding CFLAGS when I invoked make, because otherwise other
> stuff (like -m32) gets omitted. Can we do this in acinclude.m4?
>
> - CFLAGS="-Wall -O2"
> + if (test "${CFLAGS}" = ""); then
> + CFLAGS="-Wall -O2"
> + fi
> +

I was thinking of something like that, but actually never included it
until now. Fix is in CVS for libs, utils and hcidump.

> OK. I think I'm not supposed to ship a cvs snapshot -- I have to wait
> for 2.10. But I've isolated just the patch in question and added it into
> the bluez-utils-2.9-2 RPM, with the above change to inherit CFLAGS if
> they're already set.

I will use memmove for unaligned access and release libs and utils
tomorrow or the day after tomorrow. I like to test your unaligned code a
little bit more before making a release with it.

> > I did it this way, but there were reports of Sparc platforms where the
> > resulting binary should be run-tested.
>
> Hmmm. Can I revise my original answer.... don't. If the user asks for
> it, do it. Else don't.
>
> Random behavioural changes based on the characteristics of the system we
> _happen_ to build on today are probably a bad thing. Just build as
> configured and don't try to auto-adapt to _anything_ :)

Don't worry. You still have to use --enable-pie to activate it even if
configure finds out that the compile supports it.

Regards

Marcel

-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.