From: David Woodhouse <dwmw2@infradead.org>
To: BlueZ Mailing List <bluez-devel@lists.sourceforge.net>
Subject: [Bluez-devel] BNEP corruption.
Date: Mon, 06 Sep 2004 16:02:55 +0100 [thread overview]
Message-ID: <1094482974.14552.38891.camel@hades.cambridge.redhat.com> (raw)
Using a PCMCIA bluetooth card I see this frequently...
bcsp_recv: Error in BCSP hdr checksum
bcsp_recv: Out-of-order packet arrived, got 2 expected 1
bcsp_recv: Out-of-order packet arrived, got 3 expected 1
bcsp_recv: Out-of-order packet arrived, got 4 expected 1
bcsp_recv: Short BCSP packet
bcsp_recv: Out-of-order packet arrived, got 7 expected 6
bcsp_recv: Out-of-order packet arrived, got 0 expected 6
bcsp_recv: Out-of-order packet arrived, got 1 expected 6
bcsp_recv: Error in BCSP hdr checksum
At some point I'll investigate -- I thought we were supposed to be using
flow control so that really shouldn't happen. But more concerning is the
fact that this leads to silent corruption in network traffic -- we seem
to be bypassing checksums on packets received by BNEP. Let's not do
that:
--- net/bluetooth/bnep/core.c~ 2004-08-14 06:37:26.000000000 +0100
+++ net/bluetooth/bnep/core.c 2004-09-06 15:28:05.749950320 +0100
@@ -384,7 +384,7 @@
s->stats.rx_packets++;
nskb->dev = dev;
- nskb->ip_summed = CHECKSUM_UNNECESSARY;
+ nskb->ip_summed = CHECKSUM_NONE;
nskb->protocol = eth_type_trans(nskb, dev);
netif_rx_ni(nskb);
return 0;
--
dwmw2
-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
reply other threads:[~2004-09-06 15:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1094482974.14552.38891.camel@hades.cambridge.redhat.com \
--to=dwmw2@infradead.org \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox