public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Erwin Authried <eauth@softsys.co.at>
Cc: BlueZ Mailing List <bluez-users@lists.sourceforge.net>
Subject: Re: [Bluez-users] lockup problem with larger packets
Date: Thu, 28 Oct 2004 19:30:51 +0200	[thread overview]
Message-ID: <1098984652.6636.31.camel@pegasus> (raw)
In-Reply-To: <1098973897.11799.97.camel@justakiss>

Hi Erwin,

> here's a patch that reduces the execution time for "unslipping" the
> received data considerably. The patch does NOT support packets with CRC!
> This would require a little bit of additional work, I think that it
> would be better to rewrite the crc routine to calculate the whole packet
> checksum at once for better performance. I have not done that because
> the CBT100C doesn't use crc's.
> Please ignore the __fastram attribute, it's for uClinux on my specific
> board only. Functions with this attribute are placed into the cpu's
> internal 32-bit ram for faster execution.

thanks for the patch, but I can't apply it. You don't follow the coding
style and some parts are looking too hackish to me. However I don't have
enough time to look at the performance problems of the BCSP driver, but
it seems that this is necessary. So is anyone volunteering?

Regards

Marcel




-------------------------------------------------------
This Newsletter Sponsored by: Macrovision 
For reliable Linux application installations, use the industry's leading
setup authoring tool, InstallShield X. Learn more and evaluate 
today. http://clk.atdmt.com/MSI/go/ins0030000001msi/direct/01/
_______________________________________________
Bluez-users mailing list
Bluez-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-users

      reply	other threads:[~2004-10-28 17:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-22 21:21 [Bluez-users] lockup problem with larger packets Erwin Authried
2004-10-23 13:55 ` Marcel Holtmann
     [not found]   ` <1098928778.23859.32.camel@kabel>
2004-10-28 11:47     ` Marcel Holtmann
2004-10-28 14:31       ` Erwin Authried
2004-10-28 17:30         ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1098984652.6636.31.camel@pegasus \
    --to=marcel@holtmann.org \
    --cc=bluez-users@lists.sourceforge.net \
    --cc=eauth@softsys.co.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox