Hi Marcel,

Actually, maybe could a new release should be done for this?  It fixes a
lot of boot script problems on big-endian systems with things not being
shutdown properly for hidd.  I have observed that not having BT
connections cleanly closed off upsets my Apple keyboards.

Cheers,

Matthew Grant

On Sun, 2004-11-14 at 01:53, Marcel Holtmann wrote:
> Hi Matthew,
> 
> > Real reason for it is this, user-space thinks cnum field is 16 bit, kernel 
> > thinks it is 32 bit.  Bug only shows up in big-endian architectures as result
> > count is returned in top byte of what is received from the kernel, whereas on
> > i386 it is in the lowest where by fluke it works...
> > 
> > Mismatch in the kernel and user-space  header files:
> > 
> > in the kernel, net/bluetooth/hid/hdip.h: 
> > 
> > struct hidp_connlist_req {
> >         __u32  cnum;
> >         struct hidp_conninfo __user *ci;
> > };
> > 
> > in libbluetoth, include/bluetooth/hidp.h:
> > 
> > struct hidp_connlist_req {
> >         uint16_t cnum;
> >         struct hidp_conninfo *ci;
> > };
> > 
> > Which way should we go here?  We need to fix kernel or user-space, and I need your 
> > 'official' touch before I post a patch in the Debian bug report I am going to submit.
> > The fix I prefer affects the user-space bluetooth include files.
> 
> thanks for finding this mismatch. We change the userspace, because the
> kernel interface should stay stable. Actually I looked also at BNEP and
> CMTP and found that we have the same problem in CMTP. So I must have
> done this wrong in the early days of CMTP and then copied over to HIDP.
> A patch for this is in the CVS now.
> 
> Regards
> 
> Marcel
> 
-- 
===============================================================================
Matthew Grant        /\  ^/\^   grantma@anathoth.gen.nz      /~~~~\
A Linux Network Guy /~~\^/~~\_/~~~~~\_______/~~~~~~~~~~\____/******\
===GPG KeyID: 2EE20270  FingerPrint: 8C2535E1A11DF3EA5EA19125BA4E790E2EE20270==