Re: [Bluez-devel] SBC code cleanup

[Marcel Holtmann <marcel@holtmann.org>]

Hi Henryk,

> > I started with some cleaning up of the SBC code to better fit into
> > current coding conventions. My focus was on the sbc_synthesize_audio()
> > and sbc_analyze_audio() functions. 
> 
> I saw that and you're doing a good job there.

I hope that we get no performance problems with this cleanups. This all
now depends on how good the compiler optimizes and predict stuff. I
think that we need some regression tests.

>  I also saw that you
> registered sf.net/projects/sbc.

Yes, it is true. I registered the SBC library as a standalone project at
Sourceforge. Right now this is still in the setup phase, but I hope that
we can move the code over very soon. Actually this was the reason why I
tried to cleanup some things.

> > -       for (i = 0; i < 7; i++)
> > +       for (i = 0; i < 8; i++)
> 
> > Am I right, or do I miss something?
> 
> No, you're absolutely right. Actually the decoder is broken currently
> (I swear it worked when I checked in rev 1.8 of sbclib.c). I'm
> investigating...

The decoder is working for me. I tried it before I checked in my
changes.

Regards

Marcel




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel