Re: [Bluez-devel] Re: baswap neccesity

[Marcel Holtmann <marcel@holtmann.org>]

Hi,

> >>I'm reading rctest.c:
> >>In do_connect function, a call to bswap is used just before the connect 
> >>call:
> >>	baswap(&rem_addr.rc_bdaddr, strtoba(svr));
> >>
> >>In the server, baswap is again called just after the accept call
> >>
> >>Why is it neccesary? Why does the server listening at the other side 
> >>expect addresses in such byte ordering?
> > 
> > 
> > this is part of the specification. The textual representation and the
> > over-air BD_ADDR is swapped.
> > 
> > However the code above has a memory leak. Where do you found it?
> this piece of code is from the 'bluez-utils-2.13.tar.gz' package which 
> is downloadable now at the web site. Precisely in function 'int 
> do_connect(char *svr)' of rctest.c.
> It's curious, I'm sure you'd see memory leaks where I only see flowers!

the strtoba() allocates memory that is never freed. The correct way of
doing this address swapping and converting from a string is:

	str2ba(svr, &rem_addr.rc_bdaddr);

Regards

Marcel




-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel