public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Nishanth Aravamudan <nacc@us.ibm.com>
Cc: Max Krasnyansky <maxk@qualcomm.com>,
	BlueZ Mailing List <bluez-devel@lists.sourceforge.net>,
	kernel-janitors@lists.osdl.org
Subject: [Bluez-devel] Re: [PATCH 17/39] net/capi: use wait_event_interruptible_timeout()
Date: Fri, 21 Jan 2005 01:38:07 +0100	[thread overview]
Message-ID: <1106267887.7955.40.camel@pegasus> (raw)
In-Reply-To: <20050120234754.GE2600@us.ibm.com>

Hi Nishanth,

> Description: Use wait_event_interruptible_timeout() instead of custom
> wait-queue code. The first replacement is the most complicated as the various
> return conditions each indicate different things, apparently. The same effects
> are made after wait_event_interruptible_timeout() returns.

the first one makes the code look ugly. Remove it and re-submit.

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

  reply	other threads:[~2005-01-21  0:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-20 23:47 [PATCH 17/39] net/capi: use wait_event_interruptible_timeout() Nishanth Aravamudan
2005-01-21  0:38 ` Marcel Holtmann [this message]
2005-01-21 19:17   ` [UPDATE PATCH " Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1106267887.7955.40.camel@pegasus \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=maxk@qualcomm.com \
    --cc=nacc@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox