Re: [UPDATE PATCH 18/39] net/core: use wait_event_timeout()

David S. Miller
2005-01-26T05:56:39Z

On Sun, 23 Jan 2005 10:21:08 +0100
Marcel Holtmann <marcel@holtmann.org> wrote:

> we are using the wait queue from struct sock and sk_sleep is already a
> pointer. Converting from and to a pointer and later to the struct again
> to only match an API looks wrong to me and thus this API is wrong, but
> this is only my thought.
>
> Dave, any comments from you about this?

Not really. I think the API is ok, it's a tradeoff between one set
of call types putting in a deref compared to the other. And as the
patch author stated, the bluetooth side is definitely in the
minority.

To be honest, I think the decision is arbitrary.