RE: [Bluez-devel] rejecting or accepting connection request

[Marcel Holtmann <marcel@holtmann.org>]

Hi Tzahi,
 
> +	if ( IsUserAppPolicy==1 )
> +	{
> +		BT_DBG("%s Connection request: %s letting the app decide
> if to accept or reject", hdev->name);
> +		return;
> +	}
> +		

I don't think that I will add this part of your patch, because I have
plans for a policy manager.
 	
>  	conn = conn_hash_lookup_ba(hdev, cc->link_type, &cc->bdaddr);
> -	if (!conn) {
> -		hci_dev_unlock(hdev);
> -		return;
> +	if (!conn) 
> +	{
> +		if (!(conn = hci_conn_add(hdev, cc->link_type,
> &cc->bdaddr))) 
> +		{
> +			BT_ERR("No memmory for new connection");
> +			hci_dev_unlock(hdev);
> +			return;
> +		}

This part is not so unhandy to have it anyway, but you forgot to think
about what this change means if the ev->status is not zero.

Regards

Marcel




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel