public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] DUN lookup on Samsung D500 raises SIGSEGV
Date: Wed, 03 Aug 2005 20:38:52 +0200	[thread overview]
Message-ID: <1123094332.8331.34.camel@pegasus> (raw)
In-Reply-To: <42F102E2.5060608@csr.com>

Hi Steven,

> > without realy knowing the internals this looks to me like BlueZ does not
> > support 32 Bit UUIDS. It is a little bit unusual to use 32 Bit UUIDs but
> > legal. So BlueZ SDP Parser shall support them.
> 
> We've been through this before and someone also suggested that the 32 bit
> UUIDs were the problem. They're not. The Samsung D-500 DUN SDP record is
> incorrect (or at the very least bizarre) and sdptool doesn't do proper
> input validation (always a security risk).
> 
> An archived copy of the thread starts at:
> 
>   http://sourceforge.net/mailarchive/message.php?msg_id=11057683
> 
> The correct diagnosis is at:
> 
>   http://sourceforge.net/mailarchive/message.php?msg_id=11057684
> 
> I suspect sdptool is "knows" that a BluetoothProfileDescriptorList
> should be a sequence of sequences and so doesn't validate the input.
> Perhaps the way to go is to add a getNextAsSequence call to sdptool
> which looks to see if the next element in the stream is a sequence.
> If it is, it returns it, if it isn't, it wraps it in a dummy sequence
> with an appropriate length and returns that.

if someone is willing to donate one of these buggy Samsung phones, I am
happy to fix it and implement a workaround for it. If not, then this
problem will exists until someone else sends me a patch for. I am not
changing something in the SDP code without being able to test it with
real life hardware.

Regards

Marcel




-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

  reply	other threads:[~2005-08-03 18:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-03 13:10 [Bluez-devel] DUN lookup on Samsung D500 raises SIGSEGV Pedro Monjo Florit
2005-08-03 17:12 ` Peter Wippich
2005-08-03 17:46   ` Steven Singer
2005-08-03 18:38     ` Marcel Holtmann [this message]
2005-08-03 18:35   ` Marcel Holtmann
2005-08-04  8:11     ` Peter Wippich
2005-08-04  8:28       ` Marcel Holtmann
2005-08-04  8:54         ` Peter Wippich
2005-08-04  9:05           ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1123094332.8331.34.camel@pegasus \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox