linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] [PATCH] Properly replace an existing key value pair in a text file
Date: Wed, 07 Sep 2005 19:33:17 +0200	[thread overview]
Message-ID: <1126114397.10631.80.camel@blade> (raw)
In-Reply-To: <431F0F7C.9090006@tcs.hut.fi>

Hi Ville,

> Yes. I located the problem in Gentoo's bluez-utils-2.19 and since it 
> hasn't yet been fixed in the CVS repository, I'm quite certain it still 
> is present ;-)
> 
> I noticed the problem when hcid just wouldn't update the link key in 
> var/lib/bluetooth/<hwaddr>/linkkeys, even though the debug statements 
> claimed otherwise. The textfile_put() function clearly works incorrectly 
> since zero is a valid value for the len variable, but the if (len <= 0 
> || ..) check causes the the function to exit before anything is written.

this sounds plausible. Your patch is applied to the CVS. Thanks.

Regards

Marcel




-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

      reply	other threads:[~2005-09-07 17:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-07 11:17 [Bluez-devel] [PATCH] Properly replace an existing key value pair in a text file Ville Nuorvala
2005-09-07 11:57 ` Marcel Holtmann
2005-09-07 16:04   ` Ville Nuorvala
2005-09-07 17:33     ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1126114397.10631.80.camel@blade \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).