From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [Bluez-devel] [PATCH] Fix infinite loops in textfile.c From: Marcel Holtmann To: bluez-devel@lists.sourceforge.net In-Reply-To: <4321BDC2.70404@tcs.hut.fi> References: <4321BDC2.70404@tcs.hut.fi> Content-Type: text/plain Message-Id: <1126345421.5697.5.camel@blade> Mime-Version: 1.0 Sender: bluez-devel-admin@lists.sourceforge.net Errors-To: bluez-devel-admin@lists.sourceforge.net Reply-To: bluez-devel@lists.sourceforge.net List-Unsubscribe: , List-Id: BlueZ development List-Post: List-Help: List-Subscribe: , List-Archive: Date: Sat, 10 Sep 2005 11:43:41 +0200 Hi Ville, > both textfile_put() and textfile_get() go into inifinite loops if a > string matching the search key is found anywhere except at the beginning > of a line. > > Both functions may also get false positive matches if the search key > forms a substring of some other key in the same file. > > The attached patch fixes both problems, but I can split it up into two > separate parts if you wish. no need to split it. Thanks for the patch. I applied it. What do you think about writing some regression tests for the textfile library? Regards Marcel ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel