Re: [Bluez-devel] [DBUS-PATCH] cleanup

[Marcel Holtmann <marcel@holtmann.org>]

Hi Claudio,

> Minor changes:
>  - removed some logs
>  - added verification for dbus_connection_list_registered function. It
> can return FALSE if there is no memory to allocate the child entries

the patch is now in the CVS. The whitespace thing is getting better and
I hope you use an editor that is visualizing them for you.

There are some programming styles in the code that we need to change,
because this code is getting ugly otherwise. Here is a bad example:

void func(void)
{
	if (test) {
		do_something();
	}
}

This will end up in nesting statements and you have to indent to deep to
keep it readable somehow. So the preferred way is:

void func(void)
{
	if (!test)
		return;

	do_something();
}

If a function is some lines longer this is not a big problem for the
understanding of the code, but if it is indented to deep then the code
becomes hard to read.

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel