Re: [Bluez-devel] [D-BUS PATCH] Authentication

[Marcel Holtmann <marcel@holtmann.org>]

Hi Claudio,

> This is the initial patch to support authentication. There are
> improving points
> that I am planning send soon if everybody agree with my proposal.

I applied the patch, but please do the coding style right. It seems that
you still copy some parts for your old patches.

	if (sock > 0)
		close (sock);

I first prefer to use "sk" instead of "sock", but this hasn't been used
in full consistency and so I didn't corrected it. However you need to
check for (sock >= 0) in case of a socket or file descriptor and we
don't put a space between the function name and its parameters. So it
must be called "close(sock);" in any case.

It is also better to introduce more error labels than using another if
statement to check for state of a file descriptor. We now if the file
descriptor is valid or not.

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel