Re: [Bluez-devel] SBC Decoder Performance

[Marcel Holtmann <marcel@holtmann.org>]

Hi Brad,

> >>bunch of macro calls that are replaced at compile time by either
> >>floating or fixed point math.
> > 
> > but this is totally ugly.
> 
> the macros are also how the inline arm assembly gets inserted, so there
> are potentially a bunch of implementation for each macro, especially
> since 32-bit fixed is still experimental:
> 
>  - floating
>  - 64-bit fixed generic
>  - arm 64-bit asm
>  - 32-bit fixed generic
>  - arm 32-bit asm
> 
> it's ugly, but what should it look like? it doesn't look much better by
> removing floating from the list.

I haven't looked through the complete code, but these #ifdef all over
the place are ugly. They should be avoided whenever possible.

> > If the fixed point decoder is too slow, then this needs to be fixed.
> > Having too decoders won't really help.
> 
> inline asm may help but the difference is probably in the noise level.

If possible I would avoid any assembler at all. However it would be at
least something to try.

Regards

Marcel




-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel