From: Marcel Holtmann <marcel@holtmann.org>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] hciattach patch: make the device string longer
Date: Fri, 02 Dec 2005 16:03:17 +0100 [thread overview]
Message-ID: <1133535797.20834.78.camel@blade> (raw)
In-Reply-To: <439060DA.4000401@anymore.nl>
Hi Arjan,
> For our port on the HP Ipaq 1940, we want to use Bluez as the bluetooth
> library.
> Our work is mostly based at handhelds.org, we want to have the Familiar
> distribution on our devices too.
> We were having some problems with hciattach not working as it should,
> and finally pinpointed it on one specific line.
> At the top of main() in hciattach.c, the device node is put in a
> variable 'dev', which is only 20 bytes long. The problem is that our
> device is (with null-termination character) exactly 21 bytes long.
> So that's why I propose the patch at the bottom of this mail, it's
> actually a 1-character patch.
> Excuse me if I break into existing conversations, or this has already
> been fixed in CVS. (I only checked the latest release)
> Thanks in advance for your comments!
I don't get why a device node name is longer than 20 characters, but I
fixed it in the CVS. However I preferred to use PATH_MAX instead of only
30 bytes.
Regards
Marcel
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
next prev parent reply other threads:[~2005-12-02 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-02 14:57 [Bluez-devel] hciattach patch: make the device string longer Arjan Schrijver
2005-12-02 15:03 ` Marcel Holtmann [this message]
2005-12-02 15:08 ` Arjan Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1133535797.20834.78.camel@blade \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).