[Bluez-devel] [PATCH]

[Bluez-devel] [PATCH]

[Filippo Giunchedi]

Hi,
dbus 0.60 has removed the DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT flag for
dbus_bus_request_name and now that is the default behaviour, the following
patch should work:

--- dbus.c      (revision 116)
+++ dbus.c      (working copy)
@@ -874,7 +874,7 @@
        dbus_connection_set_exit_on_disconnect(connection, FALSE);

        dbus_bus_request_name(connection, BASE_INTERFACE,
-                               DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT, &error);
+                               0, &error);

        if (dbus_error_is_set(&error)) {
                syslog(LOG_ERR, "Can't get system message bus name: %s",


unfortunately I can't find a DBUS_VERSION #define to be backward
compatible with dbus < 0.60


filippo



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] [PATCH]

[Marcel Holtmann]

Hi Filippo,

> dbus 0.60 has removed the DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT flag for
> dbus_bus_request_name and now that is the default behaviour, the following
> patch should work:
> 
> --- dbus.c      (revision 116)
> +++ dbus.c      (working copy)
> @@ -874,7 +874,7 @@
>         dbus_connection_set_exit_on_disconnect(connection, FALSE);
> 
>         dbus_bus_request_name(connection, BASE_INTERFACE,
> -                               DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT, &error);
> +                               0, &error);
> 
>         if (dbus_error_is_set(&error)) {
>                 syslog(LOG_ERR, "Can't get system message bus name: %s",
> 
> 
> unfortunately I can't find a DBUS_VERSION #define to be backward
> compatible with dbus < 0.60

when D-Bus 1.0 has been released, I am going to drop support for older
versions anyway. However what you need to add is something like:

#ifndef DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT
#define DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT 0x00
#endif

This will work perfect instead of using your patch and is still backward
compatible.

Regards

Marcel




-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

[Bluez-devel] Re: [PATCH]

[Filippo Giunchedi]

On Tue, 20 Dec 2005 19:59:17 +0100, Marcel Holtmann wrote:
> when D-Bus 1.0 has been released, I am going to drop support for older
> versions anyway. However what you need to add is something like:
> 
> #ifndef DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT
> #define DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT 0x00
> #endif
> 
> This will work perfect instead of using your patch and is still backward
> compatible.

that's right! thank you, are you going to merge the above define into the
next release of bluez?

filippo



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] Re: [PATCH]

[Marcel Holtmann]

Hi Filippo,

> > when D-Bus 1.0 has been released, I am going to drop support for older
> > versions anyway. However what you need to add is something like:
> > 
> > #ifndef DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT
> > #define DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT 0x00
> > #endif
> > 
> > This will work perfect instead of using your patch and is still backward
> > compatible.
> 
> that's right! thank you, are you going to merge the above define into the
> next release of bluez?

it is already in the CVS. However I have some people doing the following
transition (instead of no flags):

DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT -> DBUS_NAME_FLAG_DO_NOT_QUEUE

Any comments on this?

Regards

Marcel




-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

[Bluez-devel] Re: Re: [PATCH]

[Filippo Giunchedi]

On Wed, 21 Dec 2005 15:11:18 +0100, Marcel Holtmann wrote:
> it is already in the CVS. However I have some people doing the following
> transition (instead of no flags):
> 
> DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT -> DBUS_NAME_FLAG_DO_NOT_QUEUE
> 
> Any comments on this?

I think it makes sense not to wait for dbus name, so
DBUS_NAME_FLAG_DO_NOT_QUEUE makes sense

filippo



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel