Linux bluetooth development
 help / color / mirror / Atom feed
From: "Martin Röhricht" <ml@felicis.org>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] possible minor bug in l2cap.c
Date: Fri, 27 Jan 2006 10:26:19 +0100	[thread overview]
Message-ID: <1138353979.7949.1.camel@localhost.localdomain> (raw)
In-Reply-To: <1137082576.20029.8.camel@localhost.localdomain>

Am Donnerstag, den 12.01.2006, 17:16 +0100 schrieb Martin R=C3=B6hricht:
> Hello together,
>=20
> I was wondering if there is an uninitialised variable in use:
> In function l2cap_config_req() we declare =C2=BBu8 rsp[64];=C2=AB and cal=
l it only
> twice:
> 	l2cap_send_cmd(conn, cmd->ident, L2CAP_CONF_RSP,
> 		l2cap_build_conf_rsp(sk, rsp, NULL), rsp);
> 	l2cap_send_cmd(conn, cmd->ident, L2CAP_CONF_RSP,
> 		l2cap_build_conf_rsp(sk, rsp, &result), rsp);
>=20
> In l2cap_build_conf_rsp() (rsp changed its name to data) we access it
> like that:
> 	struct l2cap_conf_rsp *rsp =3D data;
>         void *ptr =3D rsp->data;
>=20
> I think whatever is going to be in ptr is from now on undefined, right?
> But maybe I'm just wrong and someone could help me out?!

I was wrong -- ptr is set some lines later. Everything should be fine
with it so far.

Martin



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

      reply	other threads:[~2006-01-27  9:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-12 16:16 [Bluez-devel] possible minor bug in l2cap.c Martin Röhricht
2006-01-27  9:26 ` Martin Röhricht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1138353979.7949.1.camel@localhost.localdomain \
    --to=ml@felicis.org \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox