[Bluez-devel] Oops on removing bluetooth CF card while in use

[Bluez-devel] Oops on removing bluetooth CF card while in use

[Pavel Machek]

Hi!

I'm getting small saga with CF bluetooth card... can anyone help?

http://bugzilla.kernel.org/show_bug.cgi?id=5958

							Pavel
-- 
Thanks, Sharp!


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] Oops on removing bluetooth CF card while in use

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

Hi Pavel,

> I'm getting small saga with CF bluetooth card... can anyone help?
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=5958

do you have the full oops message for me? However it has been a while
since I worked with serial line disciplines and the serial subsystem is
changing too often, that I lost track. Does the attached patch helps or
is the problem another one. Do we need to keep track of the hangup in
the serial subsystem?

Regards

Marcel


[-- Attachment #2: patch --]
[-- Type: text/x-patch, Size: 497 bytes --]

diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
index 613673b..3366bba 100644
--- a/drivers/bluetooth/hci_ldisc.c
+++ b/drivers/bluetooth/hci_ldisc.c
@@ -192,7 +192,7 @@ static int hci_uart_flush(struct hci_dev
 
 	/* Flush any pending characters in the driver and discipline. */
 	tty_ldisc_flush(tty);
-	if (tty->driver->flush_buffer)
+	if (tty->driver && tty->driver->flush_buffer)
 		tty->driver->flush_buffer(tty);
 
 	if (test_bit(HCI_UART_PROTO_SET, &hu->flags))