Re: [Bluez-devel] Implementing the PIN helper support

[Marcel Holtmann <marcel@holtmann.org>]

Hi Johan,

> > my current idea is to have a default handler that the applications have
> > to register over org.bluez.Manager and that they can have multiple other
> > PIN handlers registered via the org.bluez.Device interface for specific
> > devices. While the default handler is permanent, all other PIN handlers
> > may expire and get removed automatically.
> 
> I think you'll still need a way to unregister the default handler, when
> e.g. a user logs out from his session (so the next user that logs in can
> register his own default handler).

I agree. In the first place I thought we can automatically unregister it
when the program ends, but in case of desktop switching we need the
Bluetooth applet playing nice.

> Using org.bluez.Manager interface for registering the default handler
> seems to me extending too much its purpose compared to hald where we
> copied it from. The only purpose of the manager interface there is to
> allow local device discovery. Placing the default handler registration
> method at the interface org.bluez.Device (or org.bluez.Device.PinAgent)
> and object path /org/bluez/Device should be enough in my opinion. If you
> want to register a handler only for a specific local device then the
> exact path for that device (e.g. /org/bluez/Device/hci0) could be used.

For the default handler the Manager interface makes perfect sense to me.
It has nothing to do with any device and it can be present even if no
Bluetooth device is attached at all. From me perspective we put every
non device specific things into the Manager interface. However I might
be missing something.

> > Do we really only need the object path? I really like to get the default
> > handler thing implemented very soon.
> 
> For the handler registration the object path should be enough. However
> we should probably rethink the org.bluez.PinAgent interface which
> currently consists of only one method: PinRequest.
> 
> The PinRequest method currently takes two arguments: remote device
> address and a boolean indicating whether the connection is incomming or
> outgoing. A third parameter should probably be added for object path of
> the local device, since that information could be used for e.g. querying
> the name of the remote device.

The interface must change. We use strings for the BD_ADDR now a clean
break is a good thing. Can you propose something?

Regards

Marcel




-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel