[Bluez-devel] hciconfig service class listing patch

[Bluez-devel] hciconfig service class listing patch

[Claudio Takahasi]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi Marcel,

while I was developing the service class for D-Bus I noticed that
there is a small bug in the hciconfig service class listing.

The sizeof is getting the pointer size instead of check the number of
array elements.


Regards,
Claudio.
--
---------------------------------------------------------
Claudio Takahasi
Instituto Nokia de Tecnologia - INdT

[-- Attachment #2: hciconfig-service-class.patch --]
[-- Type: text/x-patch, Size: 567 bytes --]

Index: tools/hciconfig.c
===================================================================
RCS file: /cvsroot/bluez/utils/tools/hciconfig.c,v
retrieving revision 1.78
diff -u -r1.78 hciconfig.c
--- tools/hciconfig.c	15 Feb 2006 09:17:52 -0000	1.78
+++ tools/hciconfig.c	23 Feb 2006 20:27:45 -0000
@@ -666,7 +666,7 @@
 		printf("\tService Classes: ");
 		if (cls[2]) {
 			int first = 1;
-			for (s = 0; s < sizeof(*services); s++)
+			for (s = 0; s < (sizeof(services) / sizeof(*services)); s++)
 				if (cls[2] & (1 << s)) {
 					if (!first)
 						printf(", ");

Re: [Bluez-devel] hciconfig service class listing patch

[Marcel Holtmann]

Hi Claudio,

> while I was developing the service class for D-Bus I noticed that
> there is a small bug in the hciconfig service class listing.
> 
> The sizeof is getting the pointer size instead of check the number of
> array elements.

good catch. Thanks.

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel