* [Bluez-devel] Re: [PATCH] hci_usb: implement suspend/resume [not found] <1137540084.4543.15.camel@localhost> @ 2006-01-18 13:13 ` Marcel Holtmann [not found] ` <1137602323.4543.29.camel@localhost> [not found] ` <200601181425.35524.oliver@neukum.org> 1 sibling, 1 reply; 4+ messages in thread From: Marcel Holtmann @ 2006-01-18 13:13 UTC (permalink / raw) To: Johannes Berg; +Cc: maxk, linux-kernel, bluez-devel Hi Johannes, > The attached patch implements suspend/resume for the hci_usb bluetooth > driver by simply killing all outstanding urbs on suspend, and re-issuing > them on resume. > > This allows me to actually use the internal bluetooth "dongle" in my > powerbook after suspend-to-ram without taking down all userland programs > (sdpd, ...) and the hci device and reloading the module. thanks for the patch. Due to the removed owner field it won't apply cleanly to 2.6.16-rc1, but I can fix this easily by myself. > +static int hci_usb_resume(struct usb_interface *intf) > +{ > + struct hci_usb *husb = usb_get_intfdata(intf); > + int i, err; > + unsigned long flags; > + if (!husb || intf == husb->isoc_iface) > + return 0; > + > + for (i = 0; i < 4; i++) { > + struct _urb_queue *q = &husb->pending_q[i]; > + struct _urb *_urb; > + spin_lock_irqsave(&q->lock, flags); > + list_for_each_entry(_urb, &q->head, list) { > + err = usb_submit_urb(&_urb->urb, GFP_ATOMIC); > + if (err) break; > + } > + spin_unlock_irqrestore(&q->lock, flags); > + if (err) > + return -EIO; > + } > + return 0; > +} What happens if hci_usb_resume() really returns -EIO? Do we have to kill the URBs again or does the USB subsystems disconnect the device in this case? Regards Marcel ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1137602323.4543.29.camel@localhost>]
* Re: [Bluez-devel] Re: [PATCH] hci_usb: implement suspend/resume [not found] ` <1137602323.4543.29.camel@localhost> @ 2006-02-09 1:08 ` John McCabe-Dansted [not found] ` <1142934130.3964.14.camel@localhost> 1 sibling, 0 replies; 4+ messages in thread From: John McCabe-Dansted @ 2006-02-09 1:08 UTC (permalink / raw) To: bluez-devel On 1/19/06, Johannes Berg <johannes@sipsolutions.net> wrote: > The attached patch implements suspend/resume for the hci_usb bluetooth > driver by simply killing all outstanding urbs on suspend, and re-issuing > them on resume. > > This allows me to actually use the internal bluetooth "dongle" in my > powerbook after suspend-to-ram without taking down all userland programs > (sdpd, ...) and the hci device and reloading the module. Anybody have success using this patch with suspend2? I get: Feb 9 13:48:32 localhost kernel: [17193418.644000] uhci_hcd 0000:00:1f.2: USB bus 1 deregistered Feb 9 13:48:32 localhost kernel: [17193418.660000] ACPI: PCI interrupt for device 0000:00:1f.2 disabled Feb 9 13:48:39 localhost kernel: [17193425.268000] Suspend2 2.2: Initiating a software suspend cycle. Feb 9 13:48:46 localhost kernel: [17193427.272000] userspace ui: Failed to contact userspace process. Feb 9 13:48:46 localhost kernel: [17193427.272000] Freezing processes Feb 9 13:48:47 localhost kernel: [17193432.404000] Stopping tasks failed. Feb 9 13:48:47 localhost kernel: [17193432.404000] Tasks that refused to be refrigerated and haven't since exited: Feb 9 13:48:47 localhost kernel: [17193432.404000] - snd-bt-scod (#2206) signalled and todo list empty. Feb 9 13:48:47 localhost kernel: [17193432.428000] Suspend2 debugging info= : Feb 9 13:48:47 localhost kernel: [17193432.428000] - SUSPEND core : 2.2 Feb 9 13:48:47 localhost kernel: [17193432.428000] - Kernel Version : 2.6.15.1-p4-s2-ll Feb 9 13:48:47 localhost kernel: [17193432.428000] - Compiler vers. : 4.0 Feb 9 13:48:47 localhost kernel: [17193432.428000] - Attempt number : 2 Feb 9 13:48:47 localhost kernel: [17193432.428000] - Parameters : 17 32 0 1 525 0 Feb 9 13:48:47 localhost kernel: [17193432.428000] - Overall expected compression percentage: 50. Feb 9 13:48:47 localhost kernel: [17193432.428000] - Compressor lzf enable= d. Feb 9 13:48:47 localhost kernel: [17193432.428000] - Swapwriter active. Feb 9 13:48:47 localhost kernel: [17193432.428000] Swap available for image: 307241 pages. Feb 9 13:48:47 localhost kernel: [17193432.428000] - Filewriter inactive. Feb 9 13:48:47 localhost kernel: [17193432.428000] - No I/O speed stats available. Feb 9 13:48:47 localhost kernel: [17193433.656000] USB Universal Host Controller Interface driver v2.3 Feb 9 13:48:47 localhost kernel: [17193433.668000] ACPI: PCI Interrupt 0000:00:1f.2[D] -> GSI 19 (level, low) -> IRQ 16 Feb 9 13:48:47 localhost kernel: [17193433.672000] PCI: Setting latency timer of device 0000:00:1f.2 to 64 -- John C. McCabe-Dansted Master's Student 94709339 (In Perth) ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1142934130.3964.14.camel@localhost>]
* [Bluez-devel] Re: [PATCH] hci_usb: implement suspend/resume [not found] ` <1142934130.3964.14.camel@localhost> @ 2006-03-21 9:52 ` Marcel Holtmann 0 siblings, 0 replies; 4+ messages in thread From: Marcel Holtmann @ 2006-03-21 9:52 UTC (permalink / raw) To: Johannes Berg; +Cc: maxk, linux-kernel, bluez-devel Hi Johannes, > > The attached patch implements suspend/resume for the hci_usb bluetooth > > driver by simply killing all outstanding urbs on suspend, and re-issuing > > them on resume. > > > > This allows me to actually use the internal bluetooth "dongle" in my > > powerbook after suspend-to-ram without taking down all userland programs > > (sdpd, ...) and the hci device and reloading the module. > > Can someone push this patch for 2.6.17 now that 2.6.16 is out? Or is > there still anything fundamentally wrong with it? I've been waiting for > it forever now ;) I will push it with some other small changes in the next few days. Regards Marcel ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <200601181425.35524.oliver@neukum.org>]
[parent not found: <1137593621.4543.22.camel@localhost>]
[parent not found: <200601181634.08869.oliver@neukum.org>]
* Re: [linux-usb-devel] Re: [PATCH] hci_usb: implement suspend/resume [not found] ` <200601181634.08869.oliver@neukum.org> @ 2006-01-18 20:46 ` Greg KH 0 siblings, 0 replies; 4+ messages in thread From: Greg KH @ 2006-01-18 20:46 UTC (permalink / raw) To: Oliver Neukum Cc: Johannes Berg, linux-usb-devel, marcel, maxk, linux-kernel, bluez-devel On Wed, Jan 18, 2006 at 04:34:08PM +0100, Oliver Neukum wrote: > Am Mittwoch, 18. Januar 2006 15:13 schrieb Johannes Berg: > > On Wed, 2006-01-18 at 14:25 +0100, Oliver Neukum wrote: > > > > > This patch is wrong. usb_kill_urb() will sleep. You must not use it under > > > a spinlock. > > > > Whoops. Good catch. I'll have to analyse the logic with the lists being > > used here (and probably add a temporary list). Will try to get a new > > patch until tomorrow. > > > > [side note: how about adding might_sleep() to usb_kill_urb? Then I'd at > > least have noticed this right away] > > Good idea. Done. thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-03-21 9:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1137540084.4543.15.camel@localhost>
2006-01-18 13:13 ` [Bluez-devel] Re: [PATCH] hci_usb: implement suspend/resume Marcel Holtmann
[not found] ` <1137602323.4543.29.camel@localhost>
2006-02-09 1:08 ` John McCabe-Dansted
[not found] ` <1142934130.3964.14.camel@localhost>
2006-03-21 9:52 ` Marcel Holtmann
[not found] ` <200601181425.35524.oliver@neukum.org>
[not found] ` <1137593621.4543.22.camel@localhost>
[not found] ` <200601181634.08869.oliver@neukum.org>
2006-01-18 20:46 ` [linux-usb-devel] " Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).