From: Marcel Holtmann <marcel@holtmann.org>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] duplication of h4 protocol broken in btuart_cs
Date: Thu, 13 Apr 2006 18:18:00 +0200 [thread overview]
Message-ID: <1144945080.11159.50.camel@localhost> (raw)
In-Reply-To: <OF1ED005D5.FC685CD1-ONC125714F.005778F6-C125714F.00581C63@sagem.com>
Hi Matthieu,
> in hci_h4.c, the h4 stack checks the len of the packet given in the header
> with h4_check_data_len.
> in btuart_cs.c, it doesn't. This could lead to skb_over_panic if the read len is wrong.
>
> I think it could be great if all drivers using h4 could use the same h4
> stack.
this would be great, but unfortunately nobody has done this. Feel free
to send in a patch to make this happen.
Regards
Marcel
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
prev parent reply other threads:[~2006-04-13 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-13 16:02 [Bluez-devel] duplication of h4 protocol broken in btuart_cs Matthieu CASTET
2006-04-13 16:18 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1144945080.11159.50.camel@localhost \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox