From: Marcel Holtmann <marcel@holtmann.org>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] [PATCH] SCO flow control
Date: Mon, 29 May 2006 22:33:59 +0200 [thread overview]
Message-ID: <1148934839.31689.116.camel@localhost> (raw)
In-Reply-To: <447B4F98.8020501@free.fr>
Hi Fabien,
> I just finished a patch to bluez that implements flow control for SCO.
please split the changes to Bluetooth core and SCO module. Your changes
to the core will conflict with the automatic sniff mode support and I
need to sort that out.
And for the core part, please be brief with any additional comments. My
rule for comments is to put them where the code is not clear by itself.
What you have done is actually over-commenting and that makes the code
harder to read and understand.
Regards
Marcel
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
next prev parent reply other threads:[~2006-05-29 20:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-29 19:46 [Bluez-devel] [PATCH] SCO flow control Fabien Chevalier
2006-05-29 20:33 ` Marcel Holtmann [this message]
2006-05-29 21:39 ` Pieter Poorthuis
2006-05-29 22:21 ` Marcel Holtmann
2006-05-30 13:28 ` Fabien Chevalier
2006-06-01 19:15 ` Marcel Holtmann
2006-06-07 20:15 ` Fabien Chevalier
2006-06-07 20:30 ` Marcel Holtmann
2006-06-09 17:05 ` Fabien Chevalier
2006-06-09 20:17 ` Marcel Holtmann
2006-06-10 9:24 ` Fabien Chevalier
2006-06-10 22:22 ` Marcel Holtmann
2006-06-10 9:59 ` Fabien Chevalier
2006-06-10 23:14 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1148934839.31689.116.camel@localhost \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).