Re: [Bluez-devel] [PATCH] SCO flow control

[Marcel Holtmann <marcel@holtmann.org>]

Hi Pieter,

> > And for the core part, please be brief with any additional comments. My
> > rule for comments is to put them where the code is not clear by itself.
> > What you have done is actually over-commenting and that makes the code
> > harder to read and understand.
> >   
> I've read the code and for me the comments are very welcome. As well as 
> your enthousiasm & code, Fabian.

the right amount of comments and the coding style has always been
something people disagree on. However the kernel follows the policy to
have clean and easy code. You should understand the code and there
should be no need for comments. The comments are used to explain parts
that are not easy to guess.

Example for these are the reasons why to put a memory barrier here or
why not using some kind of locking or the reason why this isn't a race
conditions even if it looks like one etc.

Regards

Marcel




_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel