From: Marcel Holtmann <marcel@holtmann.org>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Cc: bluez-devel@lists.sf.net
Subject: Re: [Bluez-devel] [PATCH] rfcomm 'anycommand' bug
Date: Sun, 04 Jun 2006 15:19:21 +0200 [thread overview]
Message-ID: <1149427161.8053.3.camel@localhost> (raw)
In-Reply-To: <20060603135708.GB13263@esaurito.net>
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
Hi Filippo,
> attached there is a new patch (using tabs, "set noet" for the vim lovers) for
> rfcomm, agreed it could be better. I hope it is clear enough.
now the patch is readable, but it is still worse. However it helped me
to understand what you tried to achieve. I fixed it with the attached
patch.
Regards
Marcel
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 639 bytes --]
? .deps
? .libs
? Makefile
? Makefile.in
? lexer.c
? parser.c
? parser.h
? rfcomm
Index: main.c
===================================================================
RCS file: /cvsroot/bluez/utils/rfcomm/main.c,v
retrieving revision 1.16
diff -u -r1.16 main.c
--- main.c 3 Jan 2006 13:29:01 -0000 1.16
+++ main.c 4 Jun 2006 13:17:13 -0000
@@ -621,8 +621,13 @@
argv += optind;
optind = 0;
- if (argc < 2)
- show_all = 1;
+ if (argc < 2) {
+ if (argc != 0) {
+ usage();
+ exit(1);
+ } else
+ show_all = 1;
+ }
if ((ctl = socket(AF_BLUETOOTH, SOCK_RAW, BTPROTO_RFCOMM)) < 0 ) {
perror("Can't open RFCOMM control socket");
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
[-- Attachment #4: Type: text/plain, Size: 164 bytes --]
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
next prev parent reply other threads:[~2006-06-04 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-03 13:57 [Bluez-devel] [PATCH] rfcomm 'anycommand' bug Filippo Giunchedi
2006-06-04 13:19 ` Marcel Holtmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-06-02 11:55 Filippo Giunchedi
2006-06-02 15:09 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149427161.8053.3.camel@localhost \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sf.net \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).