From: Marcel Holtmann <marcel@holtmann.org>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] RFC : H4 and BCSP proto unification
Date: Mon, 05 Jun 2006 16:10:42 +0200 [thread overview]
Message-ID: <1149516642.7696.11.camel@localhost> (raw)
In-Reply-To: <4457BEF2.90707@free.fr>
Hi Matthieu,
> this patch is an attempt to share H4 and BCSP proto for other drivers
> than hci_uart.
>
> hci_h4.c and hci_bcsp.c where expecting a hci_uart structure, I define a
> more generic one. I need to add a tx_wakeup function for BCSP.
>
> I also added 1 operation henqueue that queue a skb in the head of the
> skb list for driver that can't send all the skb data in one operation.
>
> This is far from perfect (I don't like the hci_dev pointer duplication,
> ...) and untested for hci_uart driver.
>
> Any comments will be appreciated.
we don't need anything for BCSP. So don't even bother with it, but for
H4 it makes sense to have on common code. However using an extra module
for it is a little bit too much. I would prefer using something like
libata etc. So creating a libh4 and using it would be the better
approach.
Regards
Marcel
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
prev parent reply other threads:[~2006-06-05 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-02 20:20 [Bluez-devel] RFC : H4 and BCSP proto unification matthieu castet
2006-05-29 19:05 ` matthieu castet
2006-06-05 14:10 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149516642.7696.11.camel@localhost \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).