From: Szymon Janc <szymon.janc@tieto.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFCv2 09/14] android: sdp: Reuse BlueZ SDP server in Android
Date: Thu, 03 Oct 2013 13:47:56 +0200 [thread overview]
Message-ID: <11509963.E6KuFZ7L7l@uw000953> (raw)
In-Reply-To: <20131003113512.GA2804@aemeltch-MOBL1>
Hi Andrei,
> > > From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> > >
> > > Reuse existing SDP server code in Android GPL daemon.
> > > ---
> > > Makefile.android | 7 +++++--
> > > android/Android.mk | 7 +++++++
> > > android/bt_adapter.c | 5 ++++-
> > > android/main.c | 29 +++++++++++++++++++++++++++++
> > > android/main.h | 25 +++++++++++++++++++++++++
> > > 5 files changed, 70 insertions(+), 3 deletions(-)
> > > create mode 100644 android/main.h
> > >
> > > diff --git a/Makefile.android b/Makefile.android
> > > index 3e6fec0..bf82928 100644
> > > --- a/Makefile.android
> > > +++ b/Makefile.android
> > > @@ -3,7 +3,10 @@ if ANDROID_DAEMON
> > > noinst_PROGRAMS += android/bluezd
> > >
> > > android_bluezd_SOURCES = android/main.c src/log.c \
> > > + src/sdpd-database.c src/sdpd-server.c \
> > > + src/sdpd-service.c src/sdpd-request.c \
> > > src/shared/util.h src/shared/util.c \
> > > - src/shared/mgmt.h src/shared/mgmt.c
> > > -android_bluezd_LDADD = @GLIB_LIBS@
> > > + src/shared/mgmt.h src/shared/mgmt.c \
> > > + android/bt_adapter.h android/bt_adapter.c
> > > +android_bluezd_LDADD = lib/libbluetooth-internal.la @GLIB_LIBS@
> > > endif
> > > diff --git a/android/Android.mk b/android/Android.mk
> > > index 11ac204..b0a531f 100644
> > > --- a/android/Android.mk
> > > +++ b/android/Android.mk
> > > @@ -11,6 +11,11 @@ LOCAL_SRC_FILES := \
> > > main.c \
> > > ../src/shared/mgmt.c \
> > > ../src/shared/util.c \
> > > + bt_adapter.c \
> > > + ../src/sdpd-database.c \
> > > + ../src/sdpd-service.c \
> > > + ../src/sdpd-request.c \
> > > + ../src/sdpd-server.c \
> > >
> > > LOCAL_C_INCLUDES := \
> > > $(call include-path-for, glib) \
> > > @@ -19,6 +24,7 @@ LOCAL_C_INCLUDES := \
> > > LOCAL_C_INCLUDES += \
> > > $(LOCAL_PATH)/../ \
> > > $(LOCAL_PATH)/../src \
> > > + $(LOCAL_PATH)/../lib \
> > >
> > > LOCAL_CFLAGS := -DVERSION=\"$(BLUEZ_VERSION)\"
> > >
> > > @@ -30,6 +36,7 @@ LOCAL_CFLAGS += -DSOCK_CLOEXEC=02000000 -DSOCK_NONBLOCK=04000
> > >
> > > LOCAL_SHARED_LIBRARIES := \
> > > libglib \
> > > + libbluetooth \
> > >
> > > LOCAL_MODULE := bluezd
> > >
> > > diff --git a/android/bt_adapter.c b/android/bt_adapter.c
> > > index e21d50c..5016243 100644
> > > --- a/android/bt_adapter.c
> > > +++ b/android/bt_adapter.c
> > > @@ -23,6 +23,7 @@
> > >
> > > #include "bt_adapter.h"
> > > #include "log.h"
> > > +#include "main.h"
> > > #include "src/shared/mgmt.h"
> > >
> > > struct bt_adapter *bt_adapter_new(uint16_t index, struct mgmt *mgmt_if)
> > > @@ -45,7 +46,7 @@ void adapter_start(struct bt_adapter *adapter)
> > >
> > > /* TODO: CB: report scan mode */
> > >
> > > - /* TODO: SDP start here */
> > > + sdp_start();
> >
> > Why not just start it when daemon starts? Just like in original daemon?
> >
>
> Can it start without adapter initialized? How can I open L2CAP socket?
It binds to BDADDR_ANY address.
--
BR
Szymon Janc
next prev parent reply other threads:[~2013-10-03 11:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 15:03 [RFCv2 00/14] Basic code for Android BlueZ Andrei Emeltchenko
2013-10-01 15:03 ` [RFCv2 01/14] android: Add Adapter Bluetooth HAL template Andrei Emeltchenko
2013-10-01 15:03 ` [RFCv2 02/14] android: Add Socket " Andrei Emeltchenko
2013-10-01 15:03 ` [RFCv2 03/14] android: Enable Socket interface Andrei Emeltchenko
2013-10-01 15:03 ` [RFCv2 04/14] android: Start Android Bluetooth daemon Andrei Emeltchenko
2013-10-01 15:03 ` [RFCv2 05/14] android: Add basic mgmt initialization sequence Andrei Emeltchenko
2013-10-01 15:03 ` [RFCv2 06/14] android: Create HAL API header skeleton Andrei Emeltchenko
2013-10-03 14:07 ` Szymon Janc
2013-10-04 7:16 ` Andrei Emeltchenko
2013-10-01 15:03 ` [RFCv2 07/14] android: Add adapter and device struct for BlueZ daemon Andrei Emeltchenko
2013-10-01 15:03 ` [RFCv2 08/14] android: Add Android Makefile for libbluetooth Andrei Emeltchenko
2013-10-01 15:03 ` [RFCv2 09/14] android: sdp: Reuse BlueZ SDP server in Android Andrei Emeltchenko
2013-10-03 11:23 ` Szymon Janc
2013-10-03 11:35 ` Andrei Emeltchenko
2013-10-03 11:47 ` Szymon Janc [this message]
2013-10-01 15:03 ` [RFCv2 10/14] android: Add cap to bind to port < 1024 Andrei Emeltchenko
2013-10-01 15:03 ` [RFCv2 11/14] android: Implement read_info_complete callback Andrei Emeltchenko
2013-10-01 15:03 ` [RFCv2 12/14] android: Handle mgmt changed events Andrei Emeltchenko
2013-10-01 15:03 ` [RFCv2 13/14] android: Add makefile for hciconfig Andrei Emeltchenko
2013-10-01 15:03 ` [RFCv2 14/14] android: Add makefile for hcitool Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11509963.E6KuFZ7L7l@uw000953 \
--to=szymon.janc@tieto.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox