public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] off-by-one bugfix for sdp_data_alloc
Date: Sun, 03 Sep 2006 23:28:56 +0200	[thread overview]
Message-ID: <1157318936.32195.9.camel@aeonflux.holtmann.net> (raw)
In-Reply-To: <5f30e2610609021024j205f6a51id3d4b3c0f9129a3e@mail.gmail.com>

Hi Jeff,

> The following patch against bluez-libs-3.4 fixes a problem where the
> last character of a null-terminated string is lost.  Adding the +1
> accounts for and preserves the null terminator.

the SDP strings are not NULL terminated strings. They a prefixed with a
length value. So what is the reason for storing the NULL terminator in
the records? Show me an example what actually goes wrong here.

Regards

Marcel



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

  reply	other threads:[~2006-09-03 21:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-02 17:24 [Bluez-devel] off-by-one bugfix for sdp_data_alloc Jeff Wilson
2006-09-03 21:28 ` Marcel Holtmann [this message]
2006-09-04 22:13   ` Jeff Wilson
2006-09-05  9:53     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1157318936.32195.9.camel@aeonflux.holtmann.net \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox