Re: [Bluez-devel] Proposed DTD

Marcel Holtmann
2006-11-13T06:21:58Z

Hi Denis,

> > this patch replaces string_t by sdp_buf_t and fix system bus
> > disconnection problem. Check if this patch make sense or if it is
> > better keep string_t.
>
> I agree we should replace string_t by sdp_buf_t since this avoids an extra
> strlen. However, I think that the buffer should be grown by factors. Your
> proposed solution would call realloc many times, as the append function is
> called quite frequently with small strings, but this is no biggie.
>
> Would the attached patch be better?

looks good to me.

Claudio, please review it and then commit this to the CVS.

Regards

Marcel