From: Steve Grubb <sgrubb@redhat.com>
To: linux-bluetooth@vger.kernel.org, Bastien Nocera <hadess@hadess.net>
Subject: Re: [PATCH 1/1] Fix various memory leaks
Date: Wed, 12 May 2021 22:10:55 -0400 [thread overview]
Message-ID: <11748148.O9o76ZdvQC@x2> (raw)
In-Reply-To: <6af830fc74d50c722ecb9855038a00bf6673d4e5.camel@hadess.net>
On Wednesday, May 12, 2021 6:35:54 PM EDT Bastien Nocera wrote:
> On Wed, 2021-05-12 at 13:39 -0400, Steve Grubb wrote:
> > diff --git a/obexd/plugins/filesystem.c b/obexd/plugins/filesystem.c
> > index 09bff8ad0..44e3cf3d2 100644
> > --- a/obexd/plugins/filesystem.c
> > +++ b/obexd/plugins/filesystem.c
> > @@ -415,7 +415,7 @@ static void *capability_open(const char *name,
> > int oflag, mode_t mode,
> > goto fail;
> > }
> >
> > - object->buffer = g_string_new(buf);
> > + object->buffer = buf;
> >
> > if (size)
> > *size = object->buffer->len;
>
> Pretty certain this is wrong.
Yeah, now that you mention it...that is a GString object. I guess we
g_free(buf) right after the g_string_new(). Should I resend just that one
patch or do I need to regenerate all 7 emails?
-Steve
next prev parent reply other threads:[~2021-05-13 2:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 17:39 [PATCH 1/1] Fix various memory leaks Steve Grubb
2021-05-12 18:06 ` Luiz Augusto von Dentz
2021-05-12 18:50 ` [1/1] " bluez.test.bot
2021-05-12 22:35 ` [PATCH 1/1] " Bastien Nocera
2021-05-13 2:10 ` Steve Grubb [this message]
2021-05-13 20:32 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11748148.O9o76ZdvQC@x2 \
--to=sgrubb@redhat.com \
--cc=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox