Re: [Bluez-devel] [PATCH]Dynamic Alternate Setting patch (hci_usb.c)

[Marcel Holtmann <marcel@holtmann.org>]

Hi,

> As per the discussion on #bluez channel , I am attaching a patch which
> dynamically manages the the alternate settings for SCO channels.
> The patch includes the following :
> 
> 1. It declares a work queue(config_work), which is scheduled when
>              1. There is a change in number of SCO channels OR 
>              2. There is a change in the Voice setting. 
> 
> 2. On invocation it determines the alternate setting based on the
> table given in HCI - usb spec docs. The  table is also mentioned  in
> the patch. 
> 
> 3. It then empties all the queued isochronous URBs , except those
> which are already submitted. 
> 
> 4. It then sets the alternate setting by calling
> usb_set_interface().
> 
> I have tested this patch using "scotest". 
> I am using 2.6.21-rc7 with sco-flowcontrol-v4.2.diff patch. 
> 
> Let me know if  any changes are necessary. 

having global static variables doesn't work. It will break horrible in
case you attach a second Bluetooth dongle. Also the voice setting is
stored in hci_dev and always present. So no need to copy these
information. What you need to store is the current alternate setting and
then calculate the new one. Change the setting and then store it.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel