Re: [Bluez-devel] Esco implementation patch

[Marcel Holtmann <marcel@holtmann.org>]

Hi Denis,

> Here's a modified patch that implements eSCO sockets, including incoming SCO 
> connections.  This was a merge of my previous work for the 2.4 series of 
> kernels, so some variables might be named differently than in your patch.

please make sure you use my naming of variables. Otherwise it is too
much confusion. And please create a patch relative to this one so I can
actually review it. And please keep hci_setup_sync(). Doing the
separation this way it more logical than hacking up hci_add_sco(). The
function that decides which command to use should be hci_connect().

> > this patch is incomplete. It doesn't handle incoming eSCO connections
> > and it can't handle SCO audio packets over HCI when a real eSCO
> > connection has been established.
> 
> Why do you say this? What is required in order to get eSCO packets flowing?

If you have type == ESCO_LINK then the kernel doesn't send these packets
over the transport layer.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel