public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Ohad Ben-Cohen <ohad@bencohen.org>
Cc: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] [PATCH bluez-utils] add support for Texas Instruments' BRF63xx	chips
Date: Fri, 04 May 2007 08:49:56 +0200	[thread overview]
Message-ID: <1178261396.25425.35.camel@violet> (raw)
In-Reply-To: <200704301139.44842.ohad@bencohen.org>

Hi Ohad,

> Introduces initializing procedures for Texas Instruments' BRF63xx chips.
> These procedures take care of:
> 1. Loading TI's init script
> 2. Setting up HCILL, TI's runtime power-management UART protocol

patch looks good, but needs some major cleanups. Especially the header
file stuff needs fixing. However without hardware to test this with, I
am not going to touch it.

> An additional, tiny feature, which proved useful for
> stress checkings, is added to l2test: random delays.

Please never combine totally unrelated things into one big patch. This
needs to be a separate patch.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

      reply	other threads:[~2007-05-04  6:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-30 15:39 [PATCH bluez-utils] add support for Texas Instruments' BRF63xx chips Ohad Ben-Cohen
2007-05-04  6:49 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1178261396.25425.35.camel@violet \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    --cc=ohad@bencohen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox