Re: [Bluez-devel] [Patch] Keep rfcomm device in list until it's freed

[Marcel Holtmann <marcel@holtmann.org>]

Hi Ulisses,

> > > > > Here is patch for rfcomm to keep rfcomm device in list until it's really
> > > > > unused.
> > > >
> > > >         dev = __rfcomm_dev_get(id);
> > > > +
> > > > +       if (test_bit(RFCOMM_TTY_RELEASED, &dev->flags))
> > > > +               dev = NULL;
> > > > +
> > > >         if (dev)
> > > >                 rfcomm_dev_hold(dev);
> > > >
> > > > a test_bit() and then return NULL at the beginning makes more sense. No
> > > > need to take the lock since test_bit() is atomic anyway.
> > >
> > > How do I get flags then? Function only gets device id.
> >
> > good point. I overlooked that part.
> >
> > > I noticed another bug. If __rfcomm_dev_get returns null we end up using
> > > NULL pointer. Fixed version attached.
> >
> > Please remove this part:
> >
> > -#ifndef CONFIG_BT_RFCOMM_DEBUG
> > +#ifdef CONFIG_BT_RFCOMM_DEBUG
> >
> > And use this code:
> >
> >         if (dev) {
> >                 if (test_bit(RFCOMM_TTY_RELEASED, &dev->flags))
> >                         dev = NULL;
> >                 else
> >                         rfcomm_dev_hold(dev);
> >         }
> >
> > It makes it a little bit more readable and easier to understand what we
> > are doing there.
> 
> Where is this patch? I couldn't find it. Does it solve that problem we
> had with RFCOMM_HANGUP_NOW flag?

it was attached to Ville's email. And it doesn't solve the issue with
setting RFCOMM_HANGUP_NOW flag, but that should already be solved and
the patch for that is upstream in 2.6.22-rc3.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel