On Wed, 2007-07-25 at 10:26 +0200, Marcel Holtmann wrote: > Hi Bastien, > > > > To shorten the widget names. We might better use _not_ the "Chooser" > > > word since it looks like Gtk compat stuff because the other name was > > > already taken by an older widget. > > > > fair enough. > > > > > So BluetoothDeviceButton, BluetoothDeviceSelection and > > > BluetoothDeviceSelectionDialog might be appropriate. What do you think? > > > > I'm not sure about the dialogue widgets, as I said, but the button and > > the chooser widget would be very useful. Not convinced about the adapter > > selector either though. > > if we need a dialog for the button anyway, we can even provide it as a > widget. Shouldn't be that much work, right? However we can fix the > dialog part later on. The widget itself has to come first anyway. It's just that the amount of code needed to customise the dialogue for the need of the app (as in "Connect" button, title, selecting which drop-downs to show) would be really close to creating a new dialogue. I expect most applications to use the button selection widget anyway, and for things like the wizard to use the treeview. > The device selection widget is more important than an adapter selection > widget, but I see the need for it since it wraps around D-Bus and allows > us not to worry about the details. However there are use cases for the > adapter selection. I have at least one when it comes to the Bluetooth > Analyzer application and its planned live import support. And on the > other hand we have that information inside the model anyway. Only need > to export them into a combo box or tree view. Ha. Yes, does have its uses. I can certainly hack on something like that. Here's an updated patch to common/, with the new widget name. I added the bluetooth- to the filenames, as it's the GNOME way to show the whole namespace in the header filename. I think we'll need some changes to the client for when there's no default adapter (ie. no adapter) and we show the widget, then plug in an adapter. Any ideas how you would want that implemented? Cheers -- Bastien Nocera