From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marcel Holtmann To: BlueZ development In-Reply-To: <1185561572.2848.54.camel@cookie.hadess.net> References: <1185475756.3641.329.camel@cookie.hadess.net> <1185481079.3641.339.camel@cookie.hadess.net> <1185527921.2848.1.camel@cookie.hadess.net> <1185550243.2848.46.camel@cookie.hadess.net> <1185556171.13228.26.camel@violet> <1185561572.2848.54.camel@cookie.hadess.net> Date: Fri, 27 Jul 2007 21:02:33 +0200 Message-Id: <1185562953.13228.32.camel@violet> Mime-Version: 1.0 Subject: Re: [Bluez-devel] [PATCH] bluez-gnome: "search" button for the device selection Reply-To: BlueZ development List-Id: BlueZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Sender: bluez-devel-bounces@lists.sourceforge.net Errors-To: bluez-devel-bounces@lists.sourceforge.net Hi Hadess, > > patch has been applied. However I am not okay with some of the callback > > names, but we can fix that later. > > Let me know what you want renamed to what, and I'll fix it up. I disabled the search button support. I crashes the applet. Main issue is your handling of starting and stopping discover process and then listening for the complete signal to change the button state. That is wrong we have to track the state for an adapter being in discovery or not inside the tree model. Otherwise we end up with a lot of race condition. We also need to check if an adapter is already running a discovery or is using periodic inquiry. Regards Marcel ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel