Re: [Bluez-devel] [PATCH] bluez-gnome: "search" button for the device selection

[Marcel Holtmann <marcel@holtmann.org>]

Hi Hadess,

> > > > patch has been applied. However I am not okay with some of the callback
> > > > names, but we can fix that later.
> > > 
> > > Let me know what you want renamed to what, and I'll fix it up.
> > 
> > I disabled the search button support. I crashes the applet. Main issue
> > is your handling of starting and stopping discover process and then
> > listening for the complete signal to change the button state. That is
> > wrong we have to track the state for an adapter being in discovery or
> > not inside the tree model. Otherwise we end up with a lot of race
> > condition. We also need to check if an adapter is already running a
> > discovery or is using periodic inquiry.
> 
> How else do you want to implement it? What's the backtrace from the
> applet that you've seen?

the Bluetooth client should exists only once per application. We don't
need multiple. So it is needed that we create that object only once and
then keep it alive until end of application.

We also need to track the status of the discovery procedure inside the
tree store. Then we only have to check for that there. The tree store
has a reference count and so we can't run into problems there.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel