Re: [Bluez-devel] [patch] Use buttons in notification popups

[Marcel Holtmann <marcel@holtmann.org>]

Hi Bastien,

> > > As reported here:
> > > https://bugzilla.redhat.com/show_bug.cgi?id=407551
> > > 
> > > notification-daemon kind of sucks and doesn't allow for long messages
> > > (it will clip the messages, see those screenshots:
> > > https://bugzilla.redhat.com/attachment.cgi?id=274901
> > > https://bugzilla.redhat.com/attachment.cgi?id=274911
> > > )
> > > 
> > > Attached patch removes the extra lines, and adds a button to the popup
> > > instead. It looks better, and still pops up the dialogues as expected.
> > 
> > look good to me. Any special requirements on the version of libnotify to
> > make this work?
> 
> I don't think so, but this seems to work on any recent version of
> libnotify I've seen. And it's the same API you've used (just the
> "action" is different).

I gonna double check, but otherwise the patch is fine and committed.

About the _(action). I don't think we should do the translation this
way. Lets translate the string where there actually are an not mask them
with N(). It confuses me, but you are a better expert in this area.

Regards

Marcel



-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel