Re: [Bluez-devel] [PATCH] [RESEND] make bluez GNOME UIs singletons

Chris Rivera
2007-12-03T16:50:42Z

[-- Attachment #1.1: Type: text/plain, Size: 1454 bytes --]

On Dec 3, 2007 11:25 AM, Marcel Holtmann <marcel@holtmann.org> wrote:

> Hi Chris,
>
> I meant to look into it, but never got around it. Some small comments
> about it. Don't make the applet a singleton. That is totally unneeded
> since the applet will be loaded at login.

I still think it should be a singleton. You wouldn't ever want two applets
running unless you're testing, and we have the singleton flags for that. I
don't think this hurts anything.

> For the well known names use org.bluez.properties and org.bluez.wizard
> and don't define constants for it. Simply use the string.

That's fine.

>
> For the "Present" method. Don't use the D-Bus low-level calls. It should
> be all dbus-glib. Which means we have to abstract that into an object. I
> don't know if there is a well defined way for this. If it is, it might
> be good to use that. If not, then propose something for freedesktop.org.

I thought about doing this, but it seems like overkill to define a GObject
to just expose one method. GObject isn't exactly terse either.

>
>
> And we should probably have some generic methods inside common/ instead
> of doing it again in every program.
>
> Please follow the kernel coding style. I know it is odd for a GTK
> application, but it makes it a lot easier for me.
> <https://lists.sourceforge.net/lists/listinfo/bluez-devel>

Which parts of the patch violate the kernel coding style? The function
parameter spacing?

Chris

[-- Attachment #1.2: Type: text/html, Size: 2388 bytes --]

[-- Attachment #2: Type: text/plain, Size: 309 bytes --]

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell. From the desktop to the data center, Linux is going
mainstream. Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

[-- Attachment #3: Type: text/plain, Size: 164 bytes --]