Re: [Bluez-devel] [PATCH] [RESEND] make bluez GNOME UIs singletons

Marcel Holtmann
2007-12-17T05:47:39Z

Hi Chris,

> Attached is an updated patch with the changes that we talked about.

the patch looks good, but using bluetooth_application_instance is too
long for my taste. Use bluetooth_instance to make this shorter.

Also use org.bluez.properties etc. for the service names
and /org/bluez/properties etc. for the object path.

I also like to have multiple separate patches. One that add the generic
instance code and then additional patches that adds support for it to
every application. This makes it a lot easier for me to review and apply
it.

Regards

Marcel