From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marcel Holtmann To: BlueZ development In-Reply-To: <8a8adccc0712162315v53bf668et553413d6dbc81551@mail.gmail.com> References: <8a8adccc0712161309m29c70a45x212bead7a823d808@mail.gmail.com> <1197841650.8050.39.camel@aeonflux> <8a8adccc0712161443w7ba67743jc06515240cfdf83d@mail.gmail.com> <1197847447.26210.268.camel@cookie.hadess.net> <1197853381.8050.58.camel@aeonflux> <8a8adccc0712162315v53bf668et553413d6dbc81551@mail.gmail.com> Date: Mon, 17 Dec 2007 20:04:25 +0100 Message-Id: <1197918266.8050.90.camel@aeonflux> Mime-Version: 1.0 Subject: Re: [Bluez-devel] [PATCH] Beautify about dialog Reply-To: BlueZ development List-Id: BlueZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Sender: bluez-devel-bounces@lists.sourceforge.net Errors-To: bluez-devel-bounces@lists.sourceforge.net Hi Jaap, > > > > > > Attached patch does the following > > > > > > > > > > > > * about dialog code is simpler > > > > > > > > > > you can't use gtk_dialog_run for the applet's about dialog. It will > > > > > block and thus block all PIN requests. The current code is this way for > > > > > a reason. > > > > > > > > Didn't know that. I now use g_object_set which also reduces the amount > > > > of code considerably. > > > > > > You can still use gtk_show_about_dialog(). It removes the close > > > callback, and makes sure that only one dialogue shows up, and removes a > > > lot of boiler-plate code (it doesn't use a separate main loop like > > > gtk_dialog_run does). The gtk_dialog_run avoidance in the callbacks is > > > still needed. > > > > not sure why I haven't done it that way. Maybe it was not available when > > I wrote the initial version. However now the requirements are GTK 2.10 > > or later. So if we can simplify code, I am all for it. > > > Attached two patches > > One uses gtk-show-about-dialog fix the coding style for this one. I can already see that it messes up the whitespaces. We use tabs and no whitespace in front of the ( in function declarations. > The other makes sure that the windows always get an icon I applied that patch, but at the same time I applied it to all other applications inside bluez-gnome. There is more than the applet. Regards Marcel ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel