Re: [Bluez-devel] [PATCH] [RESEND] make bluez GNOME UIs singletons

Marcel Holtmann
2007-12-17T20:17:04Z

Hi Chris,

> I wanted to distinguish between an instance already running and actual
> DBUS errors. If an instance is already running then we can exit with
> 0 since the intended action was successful (the launched application
> is now in the foreground). If, however, there are errors connecting
> to the bus then we exit with 1. It isn't a big deal though. I've
> attached an updated apps patch that gets rid of the retval parameter.

I think that is simply too complicated. If we use --singleton, it all
has to come into place. And if D-Bus fails, the application is not good
anyway. So I don't see the real benefit. If at any time later it will be
needed, we can introduce it then.

Please use use gtk_init_with_args and make the GOptionEntry data global
and static. Look at bluetooth-analyzer for an example.

Also don't translate config options and errors that are printed on the
command line. We only translate stuff inside the UI. The normal user
won't see these anyway.

Regards

Marcel