From: Marcel Holtmann <marcel@holtmann.org>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] [PATCH] Make links in about dialog launch browser/email client
Date: Sat, 22 Dec 2007 01:16:16 +0100 [thread overview]
Message-ID: <1198282576.8050.296.camel@aeonflux> (raw)
In-Reply-To: <8a8adccc0712211417o3d2c8467m543e113eee1839c6@mail.gmail.com>
Hi Jaap,
> Attached patch does this. It now uses the screen of the about dialog
can't we have a generic do_open function and then call it from both
hooks. From a code perspective it makes it simpler.
Also what is the deal with gnome-open and xdg-open. Wouldn't it be
enough to use only xdg-open. It should be present on all major distros
by now.
Coding style wise, please don't put a space between the function name
and the "(". I know it is unusual for GNOME stuff, but this one follows
the kernel coding style like all bluez-* packages. Also please respect
the 80 characters width rule. Meaning break long functions calls to
multiple lines.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
next prev parent reply other threads:[~2007-12-22 0:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 22:17 [Bluez-devel] [PATCH] Make links in about dialog launch browser/email client Jaap A. Haitsma
2007-12-22 0:16 ` Marcel Holtmann [this message]
2007-12-22 10:55 ` Jaap A. Haitsma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198282576.8050.296.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox