From: "David Stockwell" <dstockwell@frequency-one.com>
To: "Johan Hedberg" <johan.hedberg@gmail.com>,
"Lucas De Marchi" <lucas.demarchi@profusion.mobi>
Cc: <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 3/5] avrcp: get/set three-byte company-id
Date: Fri, 9 Sep 2011 07:21:31 -0500 [thread overview]
Message-ID: <11E07DE5941E41239E3CE07CF9712B64@freqoneremote> (raw)
In-Reply-To: <20110909104123.GA23711@dell.ger.corp.intel.com>
A short cut: the output is a contiguous array of uint_8, so masking with
0xFF should be unnecessary. Would this be required for non-x86 (including
x86_64) architectures?
DS
-----Original Message-----
From: Johan Hedberg
Sent: Friday, September 09, 2011 5:41 AM
To: Lucas De Marchi
Cc: linux-bluetooth@vger.kernel.org ; David Stockwell
Subject: Re: [PATCH 3/5] avrcp: get/set three-byte company-id
Hi,
On Thu, Sep 08, 2011, Lucas De Marchi wrote:
> +static void set_company_id(uint8_t cid[3], const uint32_t cid_in)
> +{
> + cid[0] = cid_in >> 16;
> + cid[1] = cid_in >> 8;
> + cid[2] = cid_in;
> +}
You seem to have forgotten the "& 0xff" part here. Other than that I
didn't seen any obvious issues in the patch set.
Johan
next prev parent reply other threads:[~2011-09-09 12:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 23:14 [PATCH 0/5] avrcp: fixes and pdu-continuation Lucas De Marchi
2011-09-08 23:14 ` [PATCH 1/5] avrcp: use LAST element on media_info_id enum Lucas De Marchi
2011-09-08 23:14 ` [PATCH 2/5] avrcp: fix handling of metadata item 0x7 Lucas De Marchi
2011-09-08 23:14 ` [PATCH 3/5] avrcp: get/set three-byte company-id Lucas De Marchi
2011-09-09 10:41 ` Johan Hedberg
2011-09-09 12:21 ` David Stockwell [this message]
2011-09-09 12:35 ` Johan Hedberg
2011-09-09 12:46 ` Johan Hedberg
2011-09-09 13:04 ` Lucas De Marchi
2011-09-09 23:19 ` David Stockwell
2011-09-08 23:14 ` [PATCH 4/5] avrcp: limit avrcp packet size to the MTU of AV/C Lucas De Marchi
2011-09-08 23:14 ` [PATCH 5/5] avrcp: implement pdu continuation request and abort Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11E07DE5941E41239E3CE07CF9712B64@freqoneremote \
--to=dstockwell@frequency-one.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox