From: Krzysztof Kozlowski <krzk@kernel.org>
To: quic_zijuhu <quic_zijuhu@quicinc.com>,
luiz.dentz@gmail.com, luiz.von.dentz@intel.com,
marcel@holtmann.org
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: qca: Support downloading board id specific NVM for WCN7850
Date: Wed, 24 Apr 2024 09:38:14 +0200 [thread overview]
Message-ID: <11cf74a5-317c-4276-8a59-ff11ddf5825f@kernel.org> (raw)
In-Reply-To: <362984a6-7567-4d06-920f-18a6fc8a4908@quicinc.com>
On 19/04/2024 09:04, quic_zijuhu wrote:
>> /* Download NVM configuration */
>> @@ -751,8 +764,7 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate,
>> "qca/hpnv%02x.bin", rom_ver);
>> break;
>> case QCA_WCN7850:
>> - snprintf(config.fwname, sizeof(config.fwname),
>> - "qca/hmtnv%02x.bin", rom_ver);
>> + qca_get_nvm_name_generic(&config, "hmt", rom_ver, boardid);
>> break;
>>
>> default:
>
> Hi luiz, marcel,
> could you code review for this change since a new product needs this
> change ?
What does your internal guide (go/upstream) tell you about pinging after
two days?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-24 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 7:49 [PATCH] Bluetooth: qca: Support downloading board id specific NVM for WCN7850 Zijun Hu
2024-04-17 8:34 ` bluez.test.bot
2024-04-19 7:04 ` [PATCH] " quic_zijuhu
2024-04-24 7:38 ` Krzysztof Kozlowski [this message]
2024-04-24 14:20 ` patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11cf74a5-317c-4276-8a59-ff11ddf5825f@kernel.org \
--to=krzk@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=luiz.von.dentz@intel.com \
--cc=marcel@holtmann.org \
--cc=quic_zijuhu@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox