Re: [Bluez-devel] [PATCH] client.c cleanup

Marcel Holtmann
2008-01-29T17:35:48Z

Hi Bastien,

> > > A couple of bugs I found in client.c:
> > > - launch test-client with a dongle inserted, remove and reinsert the
> > > dongle, the bdaddr of the device is not set anymore
> > > - launch test-client without a dongle inserted, insert it, the bdaddr is
> > > not set and there's no children to the adapter (although there are if
> > > inserted when started)
> > > - launch test-client with a dongle inserted, remove it, add another one,
> > > the set of known devices underneath hasn't changed
> > >
> > > All those problems exist in the old version of client.c, and I intend on
> > > fixing them, as well as making the search button work as expected in the
> > > device selection widget.
> >
> > Send patches when you figured it out :)
>
> I think for most of those it would mean clearing the children of the
> adapters (removing them from the tree). Not sure what's wrong about the
> bdaddr not appearing for newly inserted devices though, probably just a
> missing call.

that is a bug or missing signal. Keeping the adapter allows us to keep
the D-Bus proxy object and will prevent from duplicate signals. Removing
the adapter would mean to also remove the signal handles etc. Seemed why
to ugly for me.

Regards

Marcel