From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bastien Nocera To: BlueZ development In-Reply-To: <1201628148.6218.23.camel@violet> References: <1201227720.2389.17.camel@cookie.hadess.net> <1201626119.6218.15.camel@violet> <1201627446.2389.121.camel@cookie.hadess.net> <1201628148.6218.23.camel@violet> Date: Tue, 29 Jan 2008 18:08:10 +0000 Message-Id: <1201630090.2389.132.camel@cookie.hadess.net> Mime-Version: 1.0 Subject: Re: [Bluez-devel] [PATCH] client.c cleanup Reply-To: BlueZ development List-Id: BlueZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Sender: bluez-devel-bounces@lists.sourceforge.net Errors-To: bluez-devel-bounces@lists.sourceforge.net On Tue, 2008-01-29 at 18:35 +0100, Marcel Holtmann wrote: > Hi Bastien, > > > > > A couple of bugs I found in client.c: > > > > - launch test-client with a dongle inserted, remove and reinsert the > > > > dongle, the bdaddr of the device is not set anymore > > > > - launch test-client without a dongle inserted, insert it, the bdaddr is > > > > not set and there's no children to the adapter (although there are if > > > > inserted when started) > > > > - launch test-client with a dongle inserted, remove it, add another one, > > > > the set of known devices underneath hasn't changed > > > > > > > > All those problems exist in the old version of client.c, and I intend on > > > > fixing them, as well as making the search button work as expected in the > > > > device selection widget. > > > > > > Send patches when you figured it out :) > > > > I think for most of those it would mean clearing the children of the > > adapters (removing them from the tree). Not sure what's wrong about the > > bdaddr not appearing for newly inserted devices though, probably just a > > missing call. > > that is a bug or missing signal. Keeping the adapter allows us to keep > the D-Bus proxy object and will prevent from duplicate signals. Removing > the adapter would mean to also remove the signal handles etc. Seemed why > to ugly for me. I'm talking about removing the children (ie. the devices), not the adapter itself. Which makes sense, as they shouldn't be associated with a non-existant adapter. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel